akvo / akvo-mis / #1467

91%

main: 91%

push

coveralls-python

Feature/547 bug edit mobile assignment (#549)

* [#547] Fix mobile assignment administration level selector

- Pre-fill the Level dropdown with the level id (not level number + 1) on
  edit, so it shows the level name instead of a raw number
- Pass maxLevel to AdministrationDropdown as a 1-indexed depth, and resolve
  currLevel / showSelectAll by level number instead of level id, so the
  cascade renders and re-selection works on tenants where level ids do not
  match their depth
- Cap the assignable level by the user's own role scope (not
  profile.administration, which is the tenant root for everyone), so a
  province-scoped user can no longer pick National

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* [#547] Fix add-user role and administration validation

- Surface nested role validation errors under the "roles" key instead of a
  bare list, so a role/administration level mismatch returns a readable
  message instead of crashing DRF with "need more than 1 value to unpack";
  remove the redundant validate_roles that returned a bool
- FormRoles passes the role's level + 1 (a depth) to AdministrationInput
  rather than administration_level (a Levels id), so the administration
  picker stops at the role's level and cannot produce a level mismatch

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* [#547] Fix tenant middleware 500 on mobile-assignment tokens

A mobile-assignment token resolves request.user to AnonymousUser (the
account lives in request.auth), which has no tenant_id. On a workspace
subdomain the middleware dereferenced it and 500'd every device endpoint.
_authenticated_user now returns None for an unauthenticated resolution, so
the request is treated as anonymous and skips tenant enforcement.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

* [#547] Enforce user administration scope on data endpoints

A client-supplied administration filter replaced the caller's own scope
instead of narrowing within it, so... (continued)

8831 of 9964 branches covered (88.63%)

Branch coverage included in aggregate %.

16023 of 17415 relevant lines covered (92.01%)

0.92 hits per line