akvo / akvo-mis
90%

DEFAULT BRANCH: main
Repo Added
Files 145
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x

coverage: 90.397% (-0.004%) from 90.401%
#1337

push

coveralls-python

web-flow 
Fix platform console sign-in and invitation sessions (#506)

* Authenticate only tenant-less accounts on the platform console

The console resolves no tenant, so `login` called `authenticate` with
`tenant=None`. `TenantAwareBackend` reads a null tenant as "no tenant
context" and falls back to walking every account with that email
address, in whatever order the database returns them, returning the
first whose password matches.

An operator who also holds a workspace account under the same address,
having reused its password when accepting the invitation, was therefore
handed the workspace row -- that account predates the invitation and so
comes first -- and was then refused by the operator check with "Sign in
at your workspace address, not the main site". The invite flow permits
the pair: `OperatorInviteSerializer` refuses a second tenant-less
account, not a workspace one. Reported from a deployment where the
invited operator was an existing workspace user; it cannot reproduce
with operators whose addresses are unique to the console.

A null tenant means two different things to that backend, and only one
of them is "search everywhere". On the console it is a requirement
rather than an absence: an operator belongs to no workspace.
`tenant_less_only` says so at the call site instead of leaving the
backend to infer it. The operator check downstream can only refuse a
wrong row; it cannot pick the right one.

Preferred over merely ordering tenant-less rows first, which would also
have fixed the shadowing. Ordering leaves the console's login form
checking a submitted password against every workspace in the install,
which is a cross-workspace credential test no amount of row ordering
removes.

The trade-off is a changed answer for a workspace account typed into
the console: 401 and the generic credentials failure, where it used to
be 400 and the base domain's message, because it now matches no row
here and never reaches the operator check. The oracle that mes... (continued)

8169 of 9283 branches covered (88.0%)

Branch coverage included in aggregate %.

15204 of 16573 relevant lines covered (91.74%)

0.92 hits per line

Relevant lines Covered
16573 RELEVANT LINES 15204 COVERED LINES
0.92 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
#1337 main Fix platform console sign-in and invitation sessions (#506) * Authenticate only tenant-less accounts on the platform console The console resolves no tenant, so `login` called `authenticate` with `tenant=None`. `TenantAwareBackend` reads a null t... push web-flow coveralls-python
90.4
#1336 fix/console-login-and-invite-session Set the session cookie when an invitation is accepted `set_user_password` assembled its own response: the serialized user and a fresh access token in the body, and no `Set-Cookie`. `AUTH_TOKEN` is the only thing the SPA bootstraps a session from,... Pull #506 zuhdil coveralls-python
90.4
#1335 HEAD Merge d577b0492 into 858806b8d push web-flow coveralls-python
90.47
#1334 feature/502-data-export-question-order Merge branch 'main' into feature/502-data-export-question-order Pull #505 web-flow coveralls-python
90.48
#1333 main [#500] feat(auth): add onboarding workspace language selector (#501) * [#500] docs(design): add MT-025 onboarding language selector feature design spec * [#500] feat(auth): add language field to tenant model and migration * [#500] feat(auth): u... push web-flow coveralls-python
90.4
#1332 feature/500-onboarding-language-selector [#500] feat(frontend): add French translations to uiText catalog Pull #501 wayangalihpratama coveralls-python
90.4
#1331 HEAD Merge ec5bfc984 into d85bad6d4 push web-flow coveralls-python
90.4
#1330 feature/502-data-export-question-order [#502] fix(jobs): preserve question order and fix label resolution in data exports with tests Pull #505 wayangalihpratama coveralls-python
90.46
#1329 HEAD Merge 7d7fcdf0d into d85bad6d4 push web-flow coveralls-python
90.41
#1328 feature/500-onboarding-language-selector [#500] fix(test): eliminate timestamp flakiness in embed dashboard rename test Pull #501 wayangalihpratama coveralls-python
90.4
See All Builds (1336)