coreui / coreui-pro / 38377684672

96%

main: 94%

push

github

refactor(ListBox): prepare search text through the shared util (#1632)

ListBox prepared search text with its own `_normalizeText` plus a trim
and a lowercase at each call, and the React and Vue packages carried
their own copies with different rules. `util/option-tree` gains
`normalizeSearchText`, which trims, lowercases and, with
`searchNormalize`, decomposes the text and removes the combining
diacritics (marks that are both combining and diacritics), and
`filterOptionTree`, which narrows an options list to the options whose
label contains the query and keeps a group only with those of its
options that match. `findOptionByLabel` now ignores spaces around
either side.

Two things change here, each pinned by a spec. `searchNormalize`
removed only U+0300 to U+036F; it now removes every combining
diacritic, so Japanese voiced marks, Hebrew points and Arabic vowel
marks fold the way Latin accents do, while vowel signs of scripts such
as Devanagari and spacing characters such as `^` stay. Autocomplete
trims the typed text, and the option label, wherever it compares the
two: the list already filtered by the trimmed text, but opening the
panel, the highlight, the hint, Enter and leaving the field used it as
typed, so `Apple ` listed Apple and Enter did not take it. The combobox
page now says "combining diacritics".

7697 of 8284 branches covered (92.91%)

Branch coverage included in aggregate %.

25 of 25 new or added lines in 3 files covered. (100.0%)

13330 of 13632 relevant lines covered (97.78%)

1711.03 hits per line