coreui / coreui-pro / 38291612922

96%

main: 94%

push

github

refactor(form-validation): share the state class, server state and description writers (#1624)

Ten component files repeated the same steps to draw their validation
state: reading the server classes at build, resolving them to a state,
moving the `.is-*` class on the frame, merging the page description with
the feedback ids in `aria-describedby`, and a private set-or-remove
attribute writer in six of them. These now live in
`util/form-validation` (`getStateClasses`, `getServerState`,
`swapStateClass`, `writeDescribedBy`) and `util/index`
(`writeAttribute`).

The drawn state stays the same, with two differences. An attribute that
already holds the value is no longer set again. A RangeSlider handle or
a Rating host that carries an `aria-invalid` other than `true` now gets
`true` in the invalid state instead of keeping it, since the component
is the only writer of that attribute. Autocomplete keeps its own
description merge, which keeps ids the page adds to its input later, and
PickerBase, DateInput and DateRangeInput keep their own class swap,
which removes only a class they added.

coreui.min.js shrinks by 3.7 kB, 633 B gzip; the other five bundles by
634 to 776 B gzip.

7665 of 8253 branches covered (92.88%)

Branch coverage included in aggregate %.

81 of 81 new or added lines in 12 files covered. (100.0%)

13275 of 13572 relevant lines covered (97.81%)

1715.93 hits per line