panates / opra / 38210735960

86%

main: 86%

push

github

fix(common,client): Stop publishing browser bundles that import undeclared packages

Both esbuild configs built their `external` list from dependencies plus
peerDependencies plus **devDependencies**. A devDependency that is
actually imported at runtime therefore survived into the published
`browser.js` as a bare import of a package nobody downstream installs,
and every consumer's bundler stopped on it:

    [vite]: Rollup failed to resolve import "@browsery/fs"
            from ".../node_modules/@opra/common/browser.js"

Comparing each bundle's bare imports against what the package declares
turned up four, one of them in a package the report did not mention:

    @opra/common   @browsery/fs, path-browserify, ts-gems
    @opra/client   @browsery/type-is

They are not the same kind of thing, so they are not fixed the same way.

`ts-gems` and `@browsery/type-is` are real runtime dependencies — the
first for `asMutable`, used throughout `@opra/common`'s own source and
by its Node build too, the second by three of the client's modules. Both
move to `dependencies`. `ts-gems` resolved until now only through
`valgen`'s transitive copy.

`@browsery/fs` and `path-browserify` stand in for `node:fs`/`node:path`
in the browser build alone (see each config's `alias`). Declaring them
would make every Node consumer install two browser shims it will never
load, so they are inlined instead.

`external` is now dependencies plus peerDependencies: what a consumer's
own install will actually have, and therefore the only thing a bundle
may leave as a bare import. Anything else is inlined, which turns this
class of mistake from a broken publish into a slightly larger bundle.
`@opra/common`'s browser bundle grows from 53 KB to 56 KB gzipped;
`@opra/client`'s is unchanged.

Verified in a clean room holding only the declared dependencies: before,
a consumer build fails to resolve `path-browserify`; after, it builds,
with no unresolved dynamic imports left.

`TranslationFileStor... (continued)

4801 of 6145 branches covered (78.13%)

Branch coverage included in aggregate %.

40863 of 47000 relevant lines covered (86.94%)

312.36 hits per line