panates / opra / 37793069155

86%

main: 86%

Build Type

push

github

Committed by erayhanoglu

Commit Message

fix(testing): Buffer the request body, and close only a server we started

Two faults in `TestBackend#send`, both reported from a project testing
against it.

A request with a body answered `401` rejected with `TypeError: fetch
failed` (cause: "expected non-null body source") instead of resolving
with the 401 the test was asserting on. `send` handed `fetch` the
`Request` object itself as its init, so the body was always that
request's own one-shot stream — undici replays a 401 with credentials
(`httpNetworkOrCacheFetch`) and a stream cannot be replayed. The body is
read into a byte array first now. This never depended on
`reportProgress`, which is the only place the client itself builds a
stream body: every request with a body was one replay away from it, and
nothing but a 401 asked for the replay.

`send` also closed the server after every response, whether or not it
had started it. A test that listens itself (`app.listen(0)`) lost its
server to the first `OpraTestClient` call, and every later request —
including ones made with something other than this client — got
ECONNREFUSED. It now closes only a server it started. A
`RequestListener` is unaffected: `TestBackend` creates that server, so
it still starts and closes one per request.

`send` is an async function with a `try/finally` rather than a chain of
`then`s around a manual `resolve`/`reject`, which is what let the close
be stated once instead of once per outcome.

First tests for the package, which had a `.mocharc.cjs` and no `test`
directory: one per fault, plus two pinning the behaviour that was
already right.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Coverage Stats

4801 of 6145 branches covered (78.13%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

40863 of 47000 relevant lines covered (86.94%)

312.36 hits per line