solidjs / solid / 38169640539

78%

main: 89%

push

github

fix(signals): a pass joined only through born-held nodes is not re-derived by a lane entry (#3969) (#3980)

* fix(signals): a pass joined only through born-held nodes is not re-derived by a lane entry (#3969)

A render effect read a memo born held into a parked change and then a
verdict lane's node (isPending). enterLane treated the pass as lane work
that read a held write (REACTIVE_JOINED) and queued it to re-derive on the
committed world, but a born-held node has none: the re-run read the same
staging. The lane held, the effect re-ran on the screen, the lane showed
and re-ran it, every round, until the loop guard. Under the dev server
every component runs in a transparent memo (solid-refresh), which is the
born-held node.

A read of a node born staged no longer marks REACTIVE_STAGED_READ
(stagedRead already kept it out of stagedReaders), and enterLane's repair
needs a staged read beside the join.

Fixes #3969

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01LVm3wseHt9wRTY8LfPiHmQ

* test(web): fix two type errors in the #3969 spec

@solidjs/web#test-types failed on the new spec: `JSX` is not exported
from "solid-js" (import it from the web entry, as the other specs do),
and `prototype` is read-only on `ErrorConstructor` (define it instead of
assigning). No behaviour change; the spec still passes 4/4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017PDt8Jv6uf5xRDsrux4UwF

---------

Co-authored-by: Claude <noreply@anthropic.com>

746 of 1036 branches covered (72.01%)

Branch coverage included in aggregate %.

1079 of 1321 relevant lines covered (81.68%)

26.99 hits per line