visgl / deck.gl / 38160197144

84%

push

github

fix(core): apply GlobeView position as east/north/up meter offsets (1/2) (#10791)

* fix(core): apply GlobeView position as east/north/up meter offsets

For #10815. GlobeViewport added viewState.position along the globe's axes,
where z is the polar axis, while WebMercatorViewport, which GlobeView uses
above zoom 12, adds it east, north and up. So the camera target was off by
an amount that depends on the location, and the view jumped at zoom 12:
[0, 0, 2000] at 46.2 degrees north put the target 1.38 km north and only
1.44 km up.

Pass an east-north-up to common space rotation as the viewport
modelMatrix, which Viewport applies to position and to nothing else.

* test(core): GlobeView position across zoom 12

GlobeView#position is continuous across zoom 12: points and meter offsets move by at most 0.2 px from zoom 11.999 to 12.001, where GlobeView switches from GlobeViewport to WebMercatorViewport.

* docs(core): document position in GlobeViewState

position reaches GlobeViewport through View.makeViewport and the base map overlays set it, so document it with the MapView wording and note the behavior change in the upgrade guide.

---------

Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>

9376 of 11718 branches covered (80.01%)

Branch coverage included in aggregate %.

10 of 10 new or added lines in 1 file covered. (100.0%)

15785 of 18400 relevant lines covered (85.79%)

20039.59 hits per line