visgl / deck.gl / 38165147229

84%

push

github

fix(geo-layers): normalize legacy numeric coordinateSystem in Tile3DLayer (#10538)

* fix(geo-layers): normalize legacy numeric coordinateSystem in Tile3DLayer

deck.gl v9.3 migrated `coordinateSystem` from numeric enums to string
constants (#10140). Released tile loaders such as `@loaders.gl/i3s` still
set the old numeric value (`METER_OFFSETS = 2`) on parsed tile content, so
`Tile3DLayer._makeSimpleMeshLayer()` forwarded `2` to the shader system and
rendering failed with `Invalid coordinateSystem: 2`.

Translate the numeric values reported by tile content back to the string
constants before they reach the sublayer. Unrecognized values are passed
through unchanged so the core validation still reports them.

Fixes #10368

* test(geo-layers): cover mesh sub layer legacy coordinateSystem path

---------

Co-authored-by: Chris Gervang <chris.gervang@joby.aero>
Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>

9387 of 11722 branches covered (80.08%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

15803 of 18404 relevant lines covered (85.87%)

19950.17 hits per line