visgl / deck.gl / 38159627874

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(mapbox): guard getProjection against throw when map style is not ready (#10551)

* fix(mapbox): guard getProjection against throw when map style is not ready

map.getProjection() can throw (e.g. maplibre-gl's implementation calls
this.style.getProjection() without a guard on this.style) when invoked
before the map's style is attached — such as on the third addControl
call under React 19 StrictMode's dev-only double-invoke of mount effects.

The existing optional-chaining only guards against the method being
absent, not against the call itself throwing. Wrap the call in try/catch
and return 'mercator' as the safe default, matching what callers
(getDefaultView / MapboxOverlay#_onAddInterleaved) already expect for the
not-ready-yet case.

Fixes #10549

* Apply suggestion from @chrisgervang

* test(mapbox): cover getProjection fallback before style is set

---------

Co-authored-by: waterWang <waterWang@users.noreply.github.com>
Co-authored-by: Chris Gervang <chrisgervang@users.noreply.github.com>
Co-authored-by: Chris Gervang <chris.gervang@joby.aero>

Coverage Stats

9370 of 11716 branches covered (79.98%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

15774 of 18390 relevant lines covered (85.77%)

20037.11 hits per line