coreui / coreui-pro / 38155884347

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(Progress): drop the MutationObserver on the bar's aria attributes (#1612)

The plugin only draws the segmented variant: it counts the segments that fit
the track, caps the corner radius and rounds the fill down to whole
segments. Watching the bar's aria-valuenow, aria-valuemin and aria-valuemax
with a MutationObserver made it follow the page's state as well. Now it
reads them only when it draws: at start, when the ResizeObserver on the
track reports a size, and when update() is called, so a script that changes
the value calls update().

The plugin also looks the bar up on every draw instead of keeping the one it
found at start, so update() fills a bar the page has rendered again, and does
nothing on a .progress-stacked.progress-segmented, which has no bar of its
own and used to throw there.

Coverage Stats

7749 of 8334 branches covered (92.98%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

2 existing lines in 1 file now uncovered.

13362 of 13660 relevant lines covered (97.82%)

1636.73 hits per line