astronomer / astro-cli / 37951022867

58%

main: 45%

push

github

Warn when an APC --image-name deploy ships only the image's DAGs (#2284)

* Warn when an --image-name deploy to an image Deployment ships only the image's DAGs

After pushing an image, APC deploy runs a DAG-only deploy and ignores its
refusal on a Deployment that takes none. For an image built from the project
that is right: the runtime base's ONBUILD COPY baked the DAGs in. An
--image-name image was built elsewhere and may carry none (an image astro
package generates has only the dependencies), so the deploy exited 0 with no
DAGs and said nothing.

DagsOnlyDeploy now marks its refusal as a DagsInImageError when the
Deployment's DAG deployment type is image, still reading as the sentinel it
wraps. APC deploy prints a warning in that case when --image-name was given,
with or without --remote. The exit code, the -o json result and the plain
Dockerfile path are unchanged, as are git-sync and volume Deployments.

Co-Authored-By: Claude <noreply@anthropic.com>

* Place a Deployment's DAGs from the deploy, gate and publish its warnings, and skip an empty upload

Review follow-ups to the --image-name warning.

The image deploy already fetches the Deployment and its cluster config, so
it now says where the Deployment takes its DAGs from (deploy.Deployed.Dags:
image, upload, or elsewhere), and the CLI decides from that rather than by
error-typing the refusal of a second call. UpdateDeploymentImage returns a
Deployed too, reading the cluster config after the update (a failure to read
it does not fail the deploy). DagsInImageError is gone. A Deployment with no
DAG deployment type on a cluster that takes no DAG-only deploys counts as
image; one with no type on a cluster that does keeps today's behaviour.
isImageDagDeployment is the one check of the image type.

The warnings respect show_warnings, as the deploy's other warnings do, and
are published under -o json in a new "warnings" field (omitted when empty,
so existing results are unchanged). The image warning i... (continued)

183 of 194 new or added lines in 4 files covered. (94.33%)

40022 of 69418 relevant lines covered (57.65%)

231.23 hits per line