astronomer / astro-cli / 37968177960

58%

main: 45%

push

github

Ask Houston for the platform only when an APC command runs (#2292)

* Ask Houston for the platform only when an APC command runs

On an APC context the root asked Houston for the platform version, and
cmd/apc for its app config, while building the command tree — before
cobra had looked at argv. A host that did not answer held up every
command for two dial timeouts: `astro --help`, `astro version`, and a
mistyped command included (#2289).

Building the tree now asks nothing. apc.NeedsPlatform finds the command
a line runs in a probe tree of the APC commands, and only when it is one
of them does the root call apc.LoadPlatform before building them, so
their flags, examples and gated subcommands still match the platform.
LoadPlatform asks for the version first and skips the app config when
that fails, since the same host will not answer the second request
either. `astro login` asks for the version itself, on the APC path only.

Fixes #2289

Co-Authored-By: Claude <noreply@anthropic.com>

* Address review: help after flags, login host, stale app config

- NeedsPlatform finds `help <command>` wherever cobra would, through a
  stand-in help command in the probe, so `astro --verbosity debug help
  deployment` builds the APC tree against the platform.
- Completion words are read once, by commandWords in cmd, which
  acceptRemovedFlags now shares, instead of a second copy in cmd/apc.
- A login to a domain other than the current context's no longer asks
  the current context's Houston for its version (and waits on it); the
  version is asked for only when logging back in to that context, and a
  failure to get it is logged at debug.
- LoadPlatform clears appConfig when the version request fails, so an
  earlier load's flags do not shape the tree.

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>

79 of 81 new or added lines in 6 files covered. (97.53%)

40060 of 69458 relevant lines covered (57.68%)

231.96 hits per line