astronomer / astro-cli / 37944378026

58%

main: 45%

push

github

Tell a 1.x script what replaced each flag v2 dropped silently (#2280)

* Tell a 1.x script what replaced each flag v2 dropped silently

A walk of the 1.x and v2 command trees, in both the Astro and APC
contexts, found 50 flags that v2 removed with neither a hidden alias nor a
tombstone, so a 1.x script passing one got cobra's bare "unknown flag":

- --force (-f) on the 18 commands that ask first, now --yes (-y)
- --json and --template on the list commands, which 1.x's pkg/output gave
  every list (deployment list already tombstoned --json)
- --format on the env get and list commands, now -o
- --api-url and --deployment-id on astro api airflow, now --url and
  --deployment (-d)

removedV1Flags lists them in one table and tombstoneRemovedV1Flags
registers each on the tree that has the command, through
cliout.AddRemovedFlag, so the run fails as a usage error naming the
replacement, before any pre-run. TestRemovedV1FlagsResolve keeps every
entry pointing at a real command in the cloud or APC tree, and
TestRemovedV1FlagsSayWhatReplacedThem runs each spelling, short forms
included.

Co-Authored-By: Claude <noreply@anthropic.com>

* Report every removed 1.x flag from one registry, at the root's flag error func

The removed flags were tombstoned two ways: a path-keyed table that
registered hidden flags per command, and six AddRemovedFlag calls beside
their commands. Both made the flag known, so it never reached
trackUnknownFlag (the only telemetry on unknown flags), and a path-keyed
table missed flags 1.x defined as persistent.

Now removedFlags lists each removed flag once, by name and shorthand, and
the root's flag error func reports it when cobra finds the flag unknown on
the invoked command: after recording it in telemetry, as a usage error,
while flags parse. A command that still has the flag never gets there. An
entry's needs and under keep its message true on every command it can
reach (--force names --yes only where there is one; --api-url applies
und... (continued)

232 of 269 new or added lines in 9 files covered. (86.25%)

39871 of 69264 relevant lines covered (57.56%)

231.03 hits per line