kobotoolbox / kpi / 37910937617

84%

master: 76%

push

github

refactor(enketo): remove broken enketo_flush_cached_preview task DEV-3000 (#7678)

### 📣 Summary

Removed a background cleanup job that ran after every form preview and
never worked.

### 📖 Description

Opening a form preview used to schedule a cleanup job for 30 minutes
later. That job failed almost every time, so all it did was add errors
on the server. It's gone now, and previews work exactly as before.

### 💭 Notes

- In production the flush gets a 404 from Enketo's `DELETE
/api/v2/survey/cache` on basically every run, so each preview queued a
celery task that failed 30 min later.
- Enketo already expires these cache entries itself (it sets a 30-day
TTL when it writes them, see `cache-model.js`), so nothing piles up
without the flush.
- Self-hosted caveat: where the flush does succeed (it does on a local
kobo-install once the preview has loaded), preview cache entries now
stay until Enketo's 30-day expiry instead of 30 min.
- Flush tasks still queued at deploy time get logged as unregistered and
dropped, once. They would have 404'd anyway.

### 👀 Preview steps

1. ℹ️ have a project with a form
2. in the celery worker container, run `celery -A kobo inspect scheduled
| grep -c enketo_flush_cached_preview` and note the number
3. open the project's **Form** tab and click the eye icon (**Preview**)
4. run the same command again
5. 🔴 [on main] the number went up by 1 (a flush task is now scheduled
~30 min out)
6. 🟢 [on PR] the number didn't change, and the preview still opens
normally

10499 of 13860 branches covered (75.75%)

33479 of 40268 relevant lines covered (83.14%)

5.49 hits per line