kobotoolbox / kpi / 37812413393

84%

master: 76%

push

github

feat(auth): handling SSO registration flow DEV-1853 (#7647)

### 📣 Summary

You can now sign up with a single sign-on provider from the new login
screen, filling in only the details your provider didn't already give
us.

### 💭 Notes

Changes here:

- `jsapp/js/auth/ProviderRoute/` — new, both halves of the flow:
- `ProviderLoginRoute` — the "Log in with X" screen a direct SSO link
lands on
  - `ProviderSignupRoute` — where allauth sends the browser back
- `ProviderSignupForm` — Email / Username prefilled from the provider,
plus the legal agreement
- `ProviderRedirectButton` — a real `<form method="post">`, not a fetch
- `ProviderLoginButtons` — the provider buttons the login screen renders
  - `providerRedirect.ts` — callback URL and the `?error=` codes
- `LoginForm` / `LoginRoute` — one button per public provider from
`/environment`, under the credentials
- `legalAgreement.tsx` — the terms/privacy checkbox label, shared with
`RegisterForm`
- `routes.tsx`, `routerConstants.ts` — two routes
- `socialApp.mocks.ts` and provider handlers in `allauth.mocks.ts` — 10
story tests across the two screens, plus unit tests for the redirect
helpers
- `signup_fields.py` — Signing up via SSO with an email on a managed
domain was blocked by the "your organization requires SSO" check — the
very thing it tells you to do. That check is now skipped for SSO
signups, as it already was on the old server-rendered page.


### 👀 Preview steps

1. ℹ️ you need Django admin access, and the auth redesign flag on — put
`?ff_authRedesignEnabled=true` before the `#`, e.g.
`http://localhost:8000/?ff_authRedesignEnabled=true#/accounts/login`
2. in Django admin → Social accounts → Social applications, add a
provider and fill in its **Provider ID** (GitLab is the least painful to
set up)
3. go to `/#/accounts/login`
4. 🔴 [on main] username and password, nothing else
5. 🟢 [on PR] an "or" divider and a "Log in with GitLab" button below the
password
6. click it, log in at the provider, come... (continued)

10499 of 13862 branches covered (75.74%)

33483 of 40277 relevant lines covered (83.13%)

5.49 hits per line