iotaledger / iota / 37870057217

72%

Build Type

push

github

Committed by web-flow

Commit Message

fix(test-cluster): stop RocksDB from preallocating file in test clusters (#13118)

# Description of change

Stops RocksDB from preallocating file space in test clusters, so a
cluster should again take about 10 MiB in `TMPDIR` instead of about 3.9
GiB (numbers from #13102), and test suites that start many clusters pass
on a tmpfs `/tmp`.

- Add `typed_store::rocks::disable_fallocate()`, a process-wide switch:
databases opened afterwards with the crate's default options
(`default_db_options`, `bulk_ingestion_options`, and the `status`
database of `check_and_mark_db_corruption`) get `allow_fallocate=false`.
- The `rocksdb` crate has no setter for `allow_fallocate`, so the option
is parsed with `get_options_from_string` on the empty base options,
before anything else is set.
- `test-cluster` calls it before it starts the swarm. Production nodes
never call it, so they still preallocate.
- Background: since the `rocksdb` 0.25 bump (#12848), RocksDB is built
with `fallocate` on Linux and preallocates each write-ahead log to up to
1.1 × the write buffer size (about 282 MiB for the node stores); see
#13102.

## Links to any relevant issues

Fixes #13102

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

New test: by default a new database's OPTIONS file has
`allow_fallocate=true`, and after `disable_fallocate` it has
`allow_fallocate=false`. It has its own test binary, because the switch
affects the whole process.

While `test_additional_objects` runs, the OPTIONS file of every node
database (stores, checkpoints, epochs, indexes, gRPC indexes, consensus,
status) shows `allow_fallocate=false`.

Coverage Stats

22 of 22 new or added lines in 3 files covered. (100.0%)

240 existing lines in 14 files now uncovered.

186515 of 264440 relevant lines covered (70.53%)

444570.61 hits per line