iotaledger / iota / 37713070747

72%

Build Type

push

github

Committed by web-flow

Commit Message

chore(iota-node,typed-store,iota-e2e-tests): remove database checkpoint leftovers, add a state snapshot e2e test (#12977)

# Description of change

Last PR of the state snapshot stack: removes what the old database-copy
approach left behind and adds an end-to-end test.

- Removes `Database::checkpoint` and `DBMap::checkpoint_db`, which no
longer have callers.
- At startup, deletes the `<db-path>/db_checkpoints` directory that
earlier releases wrote. It holds hard links to SST files the live store
has since compacted away, so it keeps using disk.
- Adds a simtest in which a fullnode publishes the state snapshot of
each epoch it leaves, across two epoch changes forced by the test. The
test waits for the `_SUCCESS` marker, which is only written once the
scanned digest matches the epoch's commitment. To support it, the
fullnode config, swarm and test cluster builders get a
`with_state_snapshot_config` option.
- The startup cleanup points at #12968, which tracks removing it,
together with #12966's pruner database migration, once a release
containing them has shipped.

## Links to any relevant issues

- Stacked on #12853.
- Removal tracked in #12968.

## How the change has been tested

- [x] Basic tests (linting, compilation, formatting, unit/integration
tests)
- [x] Patch-specific tests (correctness, functionality coverage)
- [x] I have added tests that prove my fix is effective or that my
feature works
- [x] I have checked that new and existing unit tests pass locally with
my changes

- `cargo simtest -p iota-e2e-tests --test state_snapshot_tests` passes.
- The cleanup tests build a `NodeConfig`, and check that
`<db-path>/db_checkpoints` is removed while `<db-path>/live` is left
alone.
- `cargo clippy --all-targets --all-features -- -D warnings` passes over
the crates the stack changes, and so do the unit tests of `typed-store`,
`iota-snapshot`, `iota-node`, `iota-swarm-config`, `iota-config` and
`iota-core` (lib).

### Release Notes

- [x] Nodes (Validat... (continued)

Coverage Stats

57 of 61 new or added lines in 4 files covered. (93.44%)

1228 existing lines in 39 files now uncovered.

186635 of 264605 relevant lines covered (70.53%)

438997.33 hits per line