coreui / coreui-pro / 37826400157

96%

main: 94%

Build Type

push

github

Committed by web-flow

Commit Message

feat(forms): take the validation state of the date fields and pickers from options and events, not from attributes (#1591)

* feat(DateInput,TimeInput): take the validation state from options and events, not from attributes

The field took its state from a submit listener of its own, a flag set by the
invalid event and the aria-invalid the page wrote on the element. It now
follows the validation contract the multi select already uses.

- validationState sets the state, with invalid and valid as deprecated
  aliases. A given 'invalid' blocks the submit through the value field, with
  the text of the linked message or "Invalid value.", unless the field is
  disabled; a custom validity the page set on the value field stays.
- An .is-invalid or .is-valid class in the markup is read once, at start, as
  the given state. Before, the first validation pass removed it.
- The next change the user makes (a typed key, an arrow, Backspace, Delete,
  paste, cut) drops the given state before the change events fire; code
  changes keep it. setConfig with validation options alone updates the state
  without re-rendering, and dispose does not give back a class the user
  dropped.
- What a validation reports and the :user-invalid/:user-valid states of the
  value field replace the submit listener, so a submit event dispatched by
  code no longer marks the field. Measured in Chromium: after a submit
  attempt the field shows what a native required input shows in the same
  form, also with formnovalidate and when the page takes the result over in
  validate.coreui.form. A given 'valid' now wins over a reported error in
  what the field draws.
- aria-invalid lands on the sections only, never on the group, and an
  aria-invalid the page writes on the element is left alone and no longer
  passed on.
- The value field lives as long as the instance. setConfig used to replace
  it, so a picker dropped what the browser and the page recorded on it at
  every pick.
- dispose stops... (continued)

Coverage Stats

7459 of 8038 branches covered (92.8%)

Branch coverage included in aggregate %.

252 of 253 new or added lines in 7 files covered. (99.6%)

3 existing lines in 2 files now uncovered.

12911 of 13212 relevant lines covered (97.72%)

1637.83 hits per line