source-academy / plugins / 37787482201

95%

feat/add-init-infra: 67%

push

github

fix(data-visualizer): stop clipping Binary Tree View right branches (#130)

* fix(data-visualizer): stop clipping Binary Tree View right branches

The canvas-width counter for right branches checked the left-branch
condition, so right branches were never counted and were drawn past the
canvas edge. Binary Tree View also accepted a node whose data is a list
and then drew that list as if it were a branch; such trees are now left to
General Tree View.

Closes #84

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* refactor(data-visualizer): simplify typeLabel

Binary-tree classification no longer passes a list to typeLabel, so its
"array" case was unreachable and showed as an uncovered branch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(data-visualizer): don't count the root's data slot as a right branch

draw() is called with a 1px margin in the real view, so x > runningX2
(initially 0) held for the root's first box, which is level with its
"parent" because draw() passes it its own x/y. That index-0 child is the
root's data, not a right branch, yet it bumped rightCOUNTER and widened
even a single node's canvas from ~272px to 632px. Skip the root, and test
with the production margin.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

* test(data-visualizer): type the margin test parameter

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

315 of 330 branches covered (95.45%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 2 files covered. (100.0%)

605 of 616 relevant lines covered (98.21%)

48.66 hits per line