romshark / icumsg / 37698900242

98%

Build Type

push

github

Committed by romshark

Commit Message

fix: Check expected select options by name, not by count

Analyze counted the options of a select that selectOptions listed
and reported the select incomplete unless the count reached the
length of the list. A listed "other" was never counted and a name
listed twice was counted once, so either made a complete select
incomplete, and Errors reported it with nothing missing:

    {g, select, male{m} female{f} other{o}}
    selectOptions: []string{"male", "female", "other"}, Required, Reject

    Before:
      Analyze: {g, select, male{m} female{f} other{o}} incomplete
      Errors:  missing select options []

    After:
      Analyze: nothing incomplete
      Errors:  none

Analyze now checks each listed name the way ErrorSelectMissingOption
does, and MissingOptions reports a missing name once, even if it's
listed more than once:

    {g, select, male{m} other{o}}
    selectOptions: []string{"male", "female", "female"}, Required, Reject

    Before: missing select options [female,female]
    After:  missing select options [female]

Coverage Stats

20 of 21 new or added lines in 1 file covered. (95.24%)

1 existing line in 1 file now uncovered.

1740 of 1813 relevant lines covered (95.97%)

109.8 hits per line