romshark / icumsg / 37695200950

98%

Build Type

push

github

Committed by romshark

Commit Message

fix: Keep cldr_gen.go when gencldr fails

gencldr opened its output with O_TRUNC before generating and
formatting the source, so any later failure, such as a locale x/text
can't parse or source that doesn't format, left the file empty:

    $ cd internal/cldr && go run ../cmd/gencldr -pkgname invalid-name
    panic: 5:16: expected ';', found '-'

    Before: cldr_gen.go is left empty (it had 20049 bytes)
    After:  cldr_gen.go is unchanged

The source is now generated and formatted in memory first, then
written to a temporary file that's renamed over the output.
A new test also fails when cldr_gen.go is out of date with
the embedded CLDR data.

Coverage Stats

6 of 15 new or added lines in 1 file covered. (40.0%)

3 existing lines in 1 file now uncovered.

1733 of 1806 relevant lines covered (95.96%)

107.3 hits per line