romshark / icumsg / 37694406029

98%

push

github

fix: Accept string patterns as argument styles

Custom argument styles were scanned like argument names, so they ended
at the first space or pattern syntax character, and messages using
ICU's string patterns failed to tokenize:

    {n, number, #,##0.00}

    Before: ErrExpectBracketClose at 12 (the '#')
    After:  custom style "#,##0.00"

The same applied to date patterns like "yyyy-MM-dd", quoted text like
"h 'o''clock' a" and rule sets like "%spellout-ordinal". Like ICU's
MessagePattern, a style now ends at the first '}' that's neither
quoted nor closes a '{' within the style, and every apostrophe in it
starts or ends quoted text. Keywords such as "integer" are recognized
only as the whole style, so "integer, foobar" is a custom style too.

42 of 42 new or added lines in 1 file covered. (100.0%)

1613 of 1800 relevant lines covered (89.61%)

99.41 hits per line