romshark / icumsg / 37691879862

98%

Build Type

push

github

Committed by romshark

Commit Message

fix: Make Analyze traverse unconfigured selects

Analyze skipped all branches of a select when selectOptions returned
no options for it, which is what the examples do for arguments without
a policy. Choices nested in such a select were never counted or checked:

    {g, select, male{{n, plural, other{x}}} other{x}}
    selectOptions: nil, Optional, Ignore

    Before:
      Analyze: totalChoices=1, nothing incomplete
      Errors:  none

    After:
      Analyze: totalChoices=2, {n, plural, other{x}} incomplete
      Errors:  missing cardinal plural options [one]

The same check treated an empty non-nil slice like nil, so a caller
couldn't allow only "other". Now nil applies no policies, while an
empty non-nil slice expects no options besides "other":

    {g, select, male{x} other{y}}
    selectOptions: []string{}, Required, Reject

    Before:
      Analyze: nothing rejected
      Errors:  none

    After:
      Analyze: male{x} rejected
      Errors:  invalid select option

Coverage Stats

17 of 21 new or added lines in 1 file covered. (80.95%)

2 existing lines in 1 file now uncovered.

1603 of 1790 relevant lines covered (89.55%)

94.12 hits per line