aio-libs / multidict / 37641027055

86%

push

github

Drop NOINLINE from the C extension (#1739)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `NOINLINE` from all 82 C functions that still had it, and
removed the macro from `compiler.h`, so GCC makes every inlining
decision. Comments that explained why a function was forced out of line
were trimmed, and the AGENTS.md and `check_inlining.py` guidance no
longer suggests `NOINLINE`.

GCC now inlines 33 of the 82 everywhere on GIL and 29 on FT; the rest
stay out of line on their own. Most allocation and construction paths
get cheaper on both builds. On FT, `_md_get_one_owned()` and
`_md_contains_owned()` are inlined into `md_get_one()` and
`md_contains()`, which doubles both functions and adds a stack protector
to `md_get_one()`, so FT `d[key]` and `key in d` cost 2-3.3% more.
`.text` grew 3.6 KB on GIL and shrank 2.0 KB on FT.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Callgrind, Ir per op, CPython 3.14.7, `benchmarks/callgrind_driver.py
--include-multidict-only` against f09d0828; rows that moved at least 1%,
median of all 60 cells -0.10% GIL and -0.05% FT.

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict.getitem_istr` | 777.8 | 742.8 | -4.50% |
| GIL | `MultiDict.ctor_empty` | 608.0 | 587.0 | -3.45% |
| GIL | `CIMultiDict.iter_new` | 508.0 | 493.0 | -2.95% |
| GIL | `MultiDict.iter_new` | ... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line