aio-libs / multidict / 37642156089

86%

push

github

Make the remaining walk.h helpers plain static functions (#1722)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `inline` from `_md_seen_test_and_add()` and `ALWAYS_INLINE static
inline` from `md_walk_with_hash()` in `walk.h`, leaving both plain
`static`, and removes the `md_walk_with_hash` rule from
`tools/check_inlining.py` that #1701 added.

GCC now keeps one out-of-line `md_walk_with_hash()` with
`_md_seen_test_and_add()` inlined into it, shared by `getall` and
`md_walk()`; `md_walk.constprop.0` goes away, and `md_get_all()`
(outlined in #1727) folds back into `multidict_getall()`. `.text`
shrinks by 2752 bytes on GIL and 1312 on FT.

The cost is the indirect visitor call #1701 measured. Callgrind against
`409f8d1a`, Ir per call:

| build | operation | MultiDict | CIMultiDict |
|---|---|---|---|
| GIL 3.14.7 | `getall` | 840.0 -> 875.8 (+4.3%) | 888.3 -> 926.1
(+4.3%) |
| GIL 3.14.7 | `getitem_istr` | +0.7% | unchanged |
| FT 3.14.7t | `getall` | 860.4 -> 883.2 (+2.7%) | 906.6 -> 928.8
(+2.4%) |
| FT 3.14.7t | `setitem_insert` | +1.4% | +2.2% |
| FT 3.14.7t | `delitem` | +1.1% | -1.9% |
| FT 3.14.7t | `setitem_replace` | -1.3% | -2.6% |
| FT 3.14.7t | `iter_keys` | -3.6% | -3.4% |
| FT 3.14.7t | `setitem_istr` | +0.6% | -3.3% |

Every other row moved by under 1%. The FT rows other than `getall` do
not reach the changed code; they move with the layout of the smaller
binary.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelli... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line