aio-libs / multidict / 37632228161

86%

push

github

Fail check_inlining.py on out-of-line copies of CPython inlines (#1686)

<!-- Thank you for your contribution! -->

## What do these changes do?

Extends `tools/check_inlining.py` to fail when an inline function from
the CPython headers or from `pythoncapi_compat.h` gets an out-of-line
copy in the extension. We cannot annotate those functions, so such a
copy means our own code has used up the inlining budget they need. The
names are read from the checked interpreter's headers and from
`pythoncapi_compat.h`, so the list follows each Python version.

GCC already makes some copies on master. `KNOWN_CPYTHON_COPIES` lists
them so that the check can land now and the copies can be fixed one at a
time:

- FT: `Py_DECREF()` and `Py_NewRef()`, called out of line from `d[key]`,
`d.get()`, `key in d`, iteration and the bulk updates (GCC:
`inline-unit-growth` and `large-function-growth` limits reached);
- FT: `Py_XINCREF()`, GIL: `Py_XDECREF()`, from cold code only;
- GIL before 3.14: the `PyIter_NextItem()` shim, from the view set
operations.

A listed name with no copy in the current build prints a note instead of
failing, since which copies exist depends on the compiler and the Python
version. AGENTS.md says the fix belongs in our code, not in compiler
options such as `--param inline-unit-growth`.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No. The list only shrinks; a new copy fails the `Inlining` job.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, a CI tool; checked by hand,
see below)
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line