datatug / datatug-core / 37639393842

100%

push

github

feat: resolve project edition connections (#349)

DataTug projects can declare edition connections in `connections/*.json` and select them through an environment's `editionConnections`, but the project store could not resolve those names for CLI comparison. This adds optional, provider-neutral project connection reading and environment resolution without changing the existing `ProjectStore` interface.

The reader validates the published `datatug-demo-connections/v1` format, IDs, duplicate declarations, environment membership, and pending readiness. It exposes safe identity/readiness metadata and structured BigQuery project/dataset/location fields, while omitting source, descriptor, manifest, and verification URLs. Pending editions return their metadata with a typed not-ready error so a caller can use an independently configured explicit source; plans remain non-executable. An ID absent from the new catalog returns a typed not-found error for legacy catalog fallback.

A concurrent directory-item loader also had a shared error variable across workers. Its error is now local to each worker, with a mixed success/error race regression.

Validation: `CGO_ENABLED=0 go test -coverprofile=... ./...` achieved 100.0% statement coverage with zero uncovered ranges; `go vet ./...`, `golangci-lint run ./...` (0 issues), and a focused `go test -race` covering the new reader and directory-loader regression passed. The pinned current DemoDB fixture test covers 18 connections, six BigQuery editions, two plans, and dev/QA environment files.

Source commits:

- 44c657838e7d feat: resolve project edition connections
- 004a85627316 test: cover project connection resolution
- 0427e3319fda fix: isolate concurrent directory loader errors

Pull request: datatug/datatug-core#349
Review: /private/tmp/demodb-core-connection-reader-review-r2.md

251 of 251 new or added lines in 4 files covered. (100.0%)

11513 of 11513 relevant lines covered (100.0%)

1.0 hits per line