aio-libs / multidict / 37621567329

86%

push

github

Outline _md_replace_locked (#1737)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `ALWAYS_INLINE static inline` from `_md_replace_locked()`,
making it a
plain `static` function. GCC keeps it out of line for `__setitem__`, the
watched path and `MultiDict_SetItem` on both GIL and FT. No rule in
`tools/check_inlining.py` covered it; all rules still pass.

Cost (callgrind, Ir per op, CPython 3.14.7): `d[key] = v` +30 to +39 Ir
on
GIL (+4.9 to +13.1%) and +20 to +40 Ir on FT (+4.0 to +6.5%). `.text`
shrank by 512 bytes GIL and 384 bytes FT.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
existing suite covers `__setitem__`)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict.setitem_replace` | 295.1 | 333.8 | +13.11% |
| GIL | `CIMultiDict.setitem_replace` | 349.0 | 386.8 | +10.83% |
| GIL | `MultiDict.setitem_insert` | 379.2 | 410.8 | +8.33% |
| GIL | `CIMultiDict.setitem_insert` | 456.2 | 485.9 | +6.51% |
| GIL | `MultiDict.setitem_istr` | 868.8 | 911.5 | +4.91% |
| GIL | `CIMultiDict.setitem_istr` | 300.1 | 336.9 | +12.26% |
| FT | `MultiDict.setitem_replace` | 463.2 | 487.2 | +5.18% |
| FT | `CIMultiDict.setitem_replace` | 512.6 | 533.1 | +4.00% |
| FT | `MultiDict.setitem_insert` | 562.1 | 597.7 | +6.33% |
| FT | `CIMultiDict.setitem_insert` | 624.5 | 664.8 | +6.45% |
| FT | `MultiDict.setitem_... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line