aio-libs / multidict / 37615764058

86%

push

github

Outline md_get_one (#1733)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `ALWAYS_INLINE static inline` from `md_get_one()`, making it a
plain `static` function. GCC keeps one out-of-line copy shared by
`__getitem__`, `get()`, `getone()`, their proxy versions and
`MultiDict_GetItem`, on both GIL and FT. The `md_get_one` rule in
`tools/check_inlining.py` (GIL only) is removed; all other rules still
pass.

Cost (callgrind, Ir per op, CPython 3.14.7): `d[key]` +21 to +23 Ir on
GIL (+3.5 to +15.3%) and +7 to +15 Ir on FT (+1.8 to +4.1%); `get()`
miss +6.7 to +7.8% GIL, +1.8 to +5.2% FT. FT `update` also moved +0.9 to
+2.3% (inline budget re-spent elsewhere). `.text` shrank by 3328 bytes
GIL and 4704 bytes FT.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
existing suite covers lookups)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict.getitem_hit` | 144.0 | 165.0 | +14.58% |
| GIL | `CIMultiDict.getitem_hit` | 198.0 | 219.0 | +10.61% |
| GIL | `MultiDict.getitem_istr` | 735.9 | 761.5 | +3.48% |
| GIL | `CIMultiDict.getitem_istr` | 150.0 | 173.0 | +15.33% |
| GIL | `MultiDict.get_miss` | 301.1 | 324.5 | +7.77% |
| GIL | `CIMultiDict.get_miss` | 343.6 | 366.6 | +6.69% |
| FT | `MultiDict.getitem_hit` | 215.8 | 223.8 | +3.71% |
| FT | `CIMultiDict.getitem_hit` | 257.3 | 264.3 | +2.72% |
| FT | `Mul... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line