aio-libs / multidict / 37613739983

86%

push

github

Make seven _locked helpers in hashtable.h plain static (#1735)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `NOINLINE` from `_md_contains_retry_locked()`,
`_md_get_one_retry_locked()`, `_md_pop_item_locked()`,
`_md_eq_to_mapping_locked()` and `_md_repr_locked()`, and `COLD` from
`_md_del_locked_watched()` and `_md_pop_one_locked_watched()`, leaving
them plain `static`. GCC keeps all of them out of line on its own.

The five hot helpers (`_md_contains_locked`, `_md_get_one_locked`,
`_md_replace_locked`, `_md_del_locked`, `_md_pop_one_locked`) keep
`ALWAYS_INLINE`. Making them plain `static` too was measured: GCC
outlines them, and on the GIL build `d[key]` lost 17%, `key in d` 15%,
`d[key] = v` 8-13% and `del d[key]` 12%.

C extension only; the pure Python backend has no counterpart.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes attributes.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change; covered
by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Callgrind, Ir per op vs fd33d408 (3.14.7 / 3.14.7t, GCC 15), rows that
moved 1% or more:

| Operation | GIL MultiDict | GIL CIMultiDict | FT MultiDict | FT
CIMultiDict |
|---|---|---|---|---|
| `del d[key]` | +1.1% | +2.0% | -1.0% | -1.1% |
| `popitem()` | -1.8% | | -1.4% | |
| `d[key] = v`, existing | | | -1.9% | -3.4% |
| `d[key] = v`, new | | | +1.4% | +2.0% |
| `d.get(key)`, miss | | | | +2.1% |
| `d[istr] = v` | | | | -4.1% |
| iterate keys | | | -3.6% | -3.4% |

Drafted with Claude Code (Claude Opus 5.5); reviewed by <p... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line