aio-libs / multidict / 37613370105

86%

push

github

Outline md_contains (#1734)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `ALWAYS_INLINE static inline` from `md_contains()`, making it a
plain `static` function. GCC keeps one out-of-line copy
(`md_contains.part.0` on FT) shared by `multidict_sq_contains`, the
proxy and keys view `sq_contains` slots and `MultiDict_Contains`, which
become thin wrappers. No `tools/check_inlining.py` rule covered it, and
all rules still pass.

Cost (callgrind, Ir per op, CPython 3.14.7): `key in d` +1 Ir on GIL
(+0.5 to +0.8%), unchanged on FT, since FT already called an out-of-line
`sq_contains.part.0`. `.text` shrank by 4957 bytes GIL and 6295 bytes
FT.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
existing suite covers `in`)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [ ] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt` (not run locally; the fragment uses the
same words as `CHANGES/1730.misc.rst`)

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Rows that moved 0.3% or more, plus `contains_hit`:

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict` contains_hit | 127.3 | 128.3 | +0.79% |
| GIL | `CIMultiDict` contains_hit | 183.8 | 184.8 | +0.54% |
| GIL | `MultiDict` getitem_istr | 747.8 | 752.8 | +0.67% |
| FT | `MultiDict` contains_hit | 164.6 | 164.6 | 0.00% |
| FT | `CIMultiDict` contains_hit | 206.0 | 206.0 | 0.00% |
| FT | `MultiDict` get_miss | 375.7 | 372.0 | -0.98% |
| FT | `CIMultiDict` get_miss | 366.1 | 373.9 | +2.13% |
| FT | `MultiDict... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line