tarantool
/
tarantool
/
37597434520
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
525
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.755% (+0.03%) from 87.726%
push
github
sergepetrenkobox: fix a crash on fallback from IPROTO_UNKNOWN override handler On fallback from IPROTO_UNKOWN, decoder returns NULL route and an assertion just below checks that it's not a NULL. So let's put the assertion to a success branch. Another problem is that we will send an error right after it, but `iproto_decode_msg` doesn't set diag if the request is unknown. So it leads to UB. Moreover, that's just a bad design. Fix it by setting missing diag in decoder. Closes #13291 NO_DOC=bugfix (cherry picked from commit ab512e235)
71336 of 119806 branches covered (59.54%)
3 of 3 new or added lines in 1 file covered. (100.0%)
90 existing lines in 18 files now uncovered.106885 of 121799 relevant lines covered (87.76%)
1415744.86 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 59 |
96.45
|
0.09% | src/box/iproto.cc |
| 4 |
91.13
|
-0.12% | src/box/box.cc |
| 4 |
95.13
|
-0.41% | src/box/replication.cc |
| 3 |
89.94
|
-0.22% | src/box/applier.cc |
| 3 |
22.66
|
-0.06% | src/lib/uri/uri_parser.c |
| 2 |
92.73
|
-0.04% | src/box/vinyl.c |
| 2 |
85.93
|
-0.07% | src/box/xlog.c |
| 2 |
89.69
|
0.0% | src/box/xrow.c |
| 2 |
95.45
|
-4.55% | src/lib/json/json.h |
| 1 |
96.54
|
-0.28% | src/box/lua/init.c |
| 1 |
96.34
|
-0.18% | src/box/relay.cc |
| 1 |
93.43
|
-0.19% | src/box/xrow_update_field.c |
| 1 |
93.96
|
0.0% | src/lib/core/fiber.c |
| 1 |
86.67
|
-2.22% | src/lib/core/latch.h |
| 1 |
96.3
|
-3.7% | src/lib/digest/crc32_hw_impl.c |
| 1 |
97.15
|
0.2% | src/lib/msgpuck/msgpuck.h |
| 1 |
91.68
|
0.0% | src/lib/swim/swim.c |
| 1 |
97.35
|
-0.88% | src/lib/vclock/vclock.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 37597434520.1 | 525 |
87.76
|
GitHub Action Run |
