tarantool
/
tarantool
/
37597411482
88%
master: 88%
master: 88%
|
Ran
|
Jobs
1
|
Files
525
|
Run time
2min
|
Badge
Embed ▾
README BADGES
|
coverage: 87.726% (-0.008%) from 87.734%
push
github
sergepetrenkobox: fix a crash on fallback from IPROTO_UNKNOWN override handler On fallback from IPROTO_UNKOWN, decoder returns NULL route and an assertion just below checks that it's not a NULL. So let's put the assertion to a success branch. Another problem is that we will send an error right after it, but `iproto_decode_msg` doesn't set diag if the request is unknown. So it leads to UB. Moreover, that's just a bad design. Fix it by setting missing diag in decoder. Closes #13291 NO_DOC=bugfix (cherry picked from commit ab512e235)
71317 of 119806 branches covered (59.53%)
3 of 3 new or added lines in 1 file covered. (100.0%)
68 existing lines in 15 files now uncovered.106846 of 121795 relevant lines covered (87.73%)
1372294.69 hits per line
Coverage Regressions
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 20 |
96.36
|
-0.04% | src/box/iproto.cc |
| 16 |
90.13
|
-3.36% | src/box/txn_limbo_queue.c |
| 9 |
88.14
|
-7.63% | src/box/vy_regulator.c |
| 4 |
93.62
|
-0.61% | src/box/xrow_update_field.c |
| 3 |
92.0
|
-0.3% | src/box/vy_scheduler.c |
| 2 |
94.32
|
-0.29% | src/box/memtx_space.c |
| 2 |
85.99
|
-0.11% | src/box/xlog.c |
| 2 |
89.69
|
-0.07% | src/box/xrow.c |
| 2 |
81.38
|
-0.6% | src/lib/core/coio.c |
| 2 |
86.9
|
-0.29% | src/lib/core/say.c |
| 2 |
96.95
|
-0.2% | src/lib/msgpuck/msgpuck.h |
| 1 |
99.1
|
-0.3% | src/box/lua/iproto.c |
| 1 |
95.01
|
-0.21% | src/box/vy_read_iterator.c |
| 1 |
88.07
|
0.07% | src/box/vy_run.c |
| 1 |
91.68
|
0.0% | src/lib/swim/swim.c |
Jobs
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 37597411482.1 | 525 |
87.73
|
GitHub Action Run |
