|
Ran
|
Jobs
1
|
Files
525
|
Run time
1min
|
Badge
README BADGES
|
push
github
build: fix OpenSSL 3.0+ version detection The `FindOpenSSL.cmake` module tries to parse the OpenSSL version from the `OPENSSL_VERSION_NUMBER` macro definition from OpenSSL's header assuming that the version is written verbatim: ```c # define OPENSSL_VERSION_NUMBER 0x1010117fL ``` However, OpenSSL since v3 writes it as an expression, here from 3.6.4: ```c /* Synthesize OPENSSL_VERSION_NUMBER with the layout 0xMNN00PP0L */ # define OPENSSL_VERSION_NUMBER \ ( (OPENSSL_VERSION_MAJOR<<28) \ |(OPENSSL_VERSION_MINOR<<20) \ |(OPENSSL_VERSION_PATCH<<4) \ |0x0L ) ``` As a result, the version detected by this CMake module is an empty string. This is harmless for our build and it seems to affect only build logs. Anyway, it may be confusing and it hit me once in a local experiment, so I want to fix it. This commit copies the OpenSSL v3 version detection code from upstream's `FindOpenSSL.cmake`: see [1] and [2]. [1]: https://gitlab.kitware.com/cmake/cmake/-/commit/61d746e59 [2]: https://gitlab.kitware.com/cmake/cmake/-/commit/796b44737 NO_CHANGELOG=build NO_DOC=build NO_TEST=build NO_DEPS_UPDATE (cherry picked from commit 573bdfabf)
71306 of 119806 branches covered (59.52%)
106874 of 121794 relevant lines covered (87.75%)
1389024.95 hits per line
| Lines | Coverage | ∆ | File |
|---|---|---|---|
| 9 |
88.14
|
-7.63% | src/box/vy_regulator.c |
| 6 |
95.22
|
-1.25% | src/box/vy_read_iterator.c |
| 4 |
88.07
|
-0.27% | src/box/vy_run.c |
| 4 |
89.58
|
-0.11% | src/box/xrow.c |
| 4 |
81.82
|
-12.12% | src/lua/minifio.c |
| 3 |
90.48
|
-0.48% | src/box/wal.c |
| 2 |
96.45
|
0.0% | src/box/iproto.cc |
| 2 |
92.68
|
-0.04% | src/box/vinyl.c |
| 2 |
96.3
|
-3.7% | src/lib/core/backtrace.c |
| 2 |
81.38
|
-0.6% | src/lib/core/coio.c |
| 2 |
89.3
|
-0.35% | src/lua/init.c |
| 1 |
96.0
|
-4.0% | src/box/user_def.c |
| 1 |
95.21
|
-0.53% | src/box/vy_range.c |
| 1 |
85.91
|
-0.01% | src/box/xlog.c |
| 1 |
89.66
|
-1.57% | src/box/xlog.h |
| 1 |
93.87
|
-0.1% | src/lib/core/fiber.c |
| 1 |
90.38
|
-1.92% | src/lib/core/trigger.cc |
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 37615160406.1 | 525 |
87.75
|
GitHub Action Run |
| Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line | Branch Hits | Branch Misses |
|---|