aio-libs / multidict / 37597019296

86%

push

github

Drop the kind argument from _md_walk_all_scan (#1729)

<!-- Thank you for your contribution! -->

## What do these changes do?

Folds `_md_walk_all_scan()` into `md_walk_all()`, its only caller, and
reads the table kind from `md->keys->kind` instead of passing it as a
constant. The loop is now emitted once instead of once per kind,
matching what #1716 did for the `ci` flag. C extension only; the
pure-Python backend has no counterpart.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes a wrapper.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist: N/A, refactor covered by the
existing `tests/test_capi.py` walk tests
- [ ] Documentation reflects the changes: N/A
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`: N/A
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, C extension, 3.14.7: 4089 passed, 181 skipped
Tests, C extension, 3.10.17: 4093 passed, 177 skipped
Tests, pure Python (`MULTIDICT_NO_EXTENSIONS=1 ... --no-c-extensions`),
3.14.7: 1610 passed, 24 skipped
`tools/check_inlining.py` on 3.14.7 and 3.14.7t: ok, 21 and 23 rules
`make doc-spelling`: passed

Perf: `md_walk_all()` is reached only through the `MultiDict_*` C API
walk, which `benchmarks/operations.py` does not cover, so the callgrind
driver has no row for it; not measured.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line