aio-libs / multidict / 37599648533

86%

push

github

Outline md_add (#1730)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `ALWAYS_INLINE static inline` from `md_add()`, making it a plain
`static` function. GCC keeps one out-of-line copy shared by
`multidict_add` and `MultiDict_Add`. No `tools/check_inlining.py` rule
covered it, and all rules still pass.

Cost (callgrind, Ir per op, CPython 3.14.7): `add` and `add_istr` +10 to
+14 Ir, i.e. +1.3 to +3.0% GIL and +0.6 to +1.6% FT. `.text` shrank by
1792 bytes GIL and 368 bytes FT. On FT, `setitem_replace`,
`setitem_istr` and `update` moved -0.5 to -1.1% and `get_miss` +1.0% /
-2.1%; nothing else moved more than 0.3%.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
existing suite covers add)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict.add` | 460.4 | 474.3 | +3.02% |
| GIL | `CIMultiDict.add` | 532.3 | 543.6 | +2.12% |
| GIL | `MultiDict.add_istr` | 819.9 | 830.2 | +1.26% |
| GIL | `CIMultiDict.add_istr` | 458.4 | 472.3 | +3.03% |
| FT | `MultiDict.add` | 643.9 | 647.9 | +0.62% |
| FT | `CIMultiDict.add` | 705.7 | 713.7 | +1.13% |
| FT | `MultiDict.add_istr` | 995.8 | 1005.8 | +1.00% |
| FT | `CIMultiDict.add_istr` | 643.9 | 653.9 | +1.55% |

Measured with `benchmarks/callgrind_driver.py --include-multidict-only`
against 7c34e1f9.

Tests: `pytest -q` passed with the C extension on 3.14, 3.14t... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line