aio-libs / multidict / 37595849419

86%

push

github

Shift critical sections into md_to_dict, md_repr, md_eq_to_mapping and md_pop_item (#1728)

<!-- Thank you for your contribution! -->

## What do these changes do?

`md_to_dict()`, `md_repr()`, `md_eq_to_mapping()` and `md_pop_item()`
now take the multidict's critical section themselves, around a
`_md_*_locked()` body, the same shape as `md_pop_all()`. Their callers
(`to_dict()`, the five `__repr__` slots, `tp_richcompare` and
`popitem()`) drop their own lock blocks. `md_pop_item()` also takes over
the pending watcher flush, and the richcompare mapping branch no longer
holds the lock while it probes `other` for `keys()`, which never touched
the multidict.

C extension only; the pure-Python backend has no critical sections.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No; it removes duplicated lock blocks from the callers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, refactor covered by the
existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests, before the sync with master: 3.13.2 GIL 4089 passed; 3.10.17 GIL
4093 passed; 3.14.7t FT 4074 passed; 3.13.2 pure Python
(`--no-c-extensions`) 1610 passed.
Tests, after the sync with master: 3.13.2 GIL 4089 passed (other legs
not re-run).
Inlining: `tools/check_inlining.py` ok on 3.14.7 (21 rules) and 3.14.7t
(23 rules); the new wrappers inline into their callers and the
`_md_*_locked` bodies stay out of line as the old helpers were.
Docs: `make doc-spelli... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line