aio-libs / multidict / 37594766750

86%

push

github

Outline md_get_all (#1727)

<!-- Thank you for your contribution! -->

## What do these changes do?

Dropped `ALWAYS_INLINE static inline` from `md_get_all()`, making it a
plain `static` function. GCC keeps one out-of-line copy shared by
`multidict_getall` and `multidict_proxy_getall`, so the #1530 rule in
`tools/check_inlining.py` no longer holds and was removed.

Cost (callgrind, Ir per op, CPython 3.14.7): `getall` +20 to +24 Ir,
i.e. +2.4% GIL and +2.7 to +2.9% FT for both `MultiDict` and
`CIMultiDict`. On FT, `setdefault_new` moved -1.5% and `MultiDict`
`contains_hit` -1.4%; nothing else moved more than 0.3%.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
existing suite covers getall)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

<details>
<summary>Agent run details (optional, for reviewers)</summary>

| Build | Operation | Before | After | Change |
|---|---|---|---|---|
| GIL | `MultiDict.getall` | 820.0 | 840.0 | +2.44% |
| GIL | `CIMultiDict.getall` | 866.3 | 888.3 | +2.54% |
| FT | `MultiDict.getall` | 836.4 | 860.4 | +2.87% |
| FT | `CIMultiDict.getall` | 880.8 | 904.8 | +2.72% |

Measured with `benchmarks/callgrind_driver.py --include-multidict-only`
against 1a94ccde.

Tests: `pytest -q` passed with the C extension on 3.14, 3.14t and 3.10,
and with `MULTIDICT_NO_EXTENSIONS=1 --no-c-extensions` on 3.14.
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t.
Docs: `make doc-spelling` passed.
</details>

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line