coreui / coreui-pro / 37542990866

94%

push

github

fix(TimePicker): keep an empty picker empty on cancel, start the first pick at local midnight (#1581)

* fix(TimePicker): keep an empty picker empty on cancel, start the first pick at local midnight

Opening an empty picker stored new Date(null), the UTC epoch, as the value to
restore, so Cancel filled the input with that instant in local time (7:00 PM
in New York, 1:00 AM in Warsaw, 12:00 AM in UTC) and emitted it. The picker
now remembers that it was empty and Cancel restores the empty value.

The first pick on an empty picker started from new Date('1970-01-01'), which
is parsed as UTC midnight, so the parts the user had not picked yet carried
the UTC offset (picking 30 minutes in New York gave 7:30 PM). It now starts
from local midnight.

* fix(TimePicker): reset the meridiem when cancel empties the picker

Cancel back to an empty picker left _ampm on what the user had picked, so the rebuilt selects showed AM while the next hour landed in PM.

* build: raise the coreui.bundle.js and coreui.js bundlewatch ceilings by 0.25 kB

The time picker fix adds 109 B to coreui.bundle.js and 104 B to coreui.js (gzip -9, against main), which pushes both past ceilings that the 5.29.0 release left a few bytes away. The minified bundles grow by 5-7 B and stay within budget.

4151 of 4561 branches covered (91.01%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

7510 of 7794 relevant lines covered (96.36%)

734.91 hits per line