aio-libs / multidict / 37526105687

86%

push

github

Make the getitem, contains and get slots plain static functions (#1718)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE static inline` from `multidict_mp_subscript()`,
`multidict_sq_contains()`, `multidict_get()`, `multidict_getone()` and
`multidict_getall()`, leaving them plain `static`. They were forced
inline only so that the `MultiDictProxy` wrappers got their own copy of
each body; the proxy versions now compile to a single `jmp` into the
`MultiDict` function.

Callgrind, 3.14.7, instructions per operation, base vs this branch. The
GIL build is unchanged on the lookup rows. On FT the lookups pay a few
instructions:

| Operation (FT) | `MultiDict` | `CIMultiDict` |
|---|---|---|
| `key in d` | +4.0 Ir (+2.4%) | +6.0 Ir (+2.8%) |
| `d[key]` | +3.0 Ir (+1.4%) | +2.0 Ir (+0.8%) |
| `d.get(key)`, miss | +2.6 Ir (+0.7%) | +1.8 Ir (+0.5%) |
| every other row | under 0.2%, except `setdefault_new` (-1.5%) | same |

The `key in d` cost comes from GCC splitting `multidict_sq_contains()`
into a `str` subclass check and a jump to
`multidict_sq_contains.part.0`; the `d[key]` and `get()` deltas follow
from a codegen shift in `_md_get_one_owned()`. Keeping `ALWAYS_INLINE`
on `multidict_sq_contains()` alone is an option if that cost is not
worth the smaller binary.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes five forced inlines.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
covered by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Cla... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line