aio-libs / multidict / 37526031658

86%

push

github

Make the proxy copy, to_dict and richcompare tail calls (#1717)

<!-- Thank you for your contribution! -->

## What do these changes do?

Marks `multidict_copy()`, `multidict_to_dict()` and
`multidict_tp_richcompare()` as `NOINLINE`. They were already plain
`static`, but GCC inlined each of them into its one-line
`MultiDictProxy` wrapper, so the binary carried two copies of each body
(on 3.14.7t: 137, 124 and 528 bytes). The proxy wrappers now compile to
a single `jmp`.

`multidict_proxy_tp_repr()` is left alone; it passes the proxy itself to
`md_repr()`, so it is not a copy of `multidict_tp_repr()`.

Callgrind, 3.14.7, instructions per operation, base vs this branch: no
row regressed on either build. The GIL build is unchanged; on FT the
only movement is `setdefault_new` (-10 to -12 Ir) and `iter_items` (-2
Ir), both outside the touched functions.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, three `NOINLINE` markers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
covered by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); to be reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q --no-cov` passed on the C extension under 3.14.7 GIL
(4089 passed), 3.14.7t FT (4074 passed) and 3.10 (4093 passed), and on
the pure-Python build with `--no-c-extensions` (1610 passed).
Inlining: `tools/check_inlining.py` ok on 3.14.7 and 3.14.7t; `--show`
on the three proxy wrappers lists only the `MultiDict` function they
jum... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line