aio-libs / multidict / 37518600739

86%

push

github

Drop the compile-time ci specialization (#1716)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops the compile-time `bool ci` specialization from the C extension.
The helpers read `md->is_ci` instead of taking it as a parameter, so the
per-class copies (`cimultidict_*` and `cimultidict_proxy_*` entry
points, `md_del_ci`/`_cs`, `md_pop_one_ci`/`_cs`, `md_replace_ci`/`_cs`,
the per-class kwnames and dict extend helpers) and the dispatchers
between them are gone. `CIMultiDict` and `CIMultiDictProxy` share the
`MultiDict` method tables again, as before #1644/#1648, and inherit the
mapping slots. Helpers left with a single caller (`_multidict_getall`,
`_multidict_get`, `_multidict_add`, `_multidict_setdefault`) are folded
into it. A function that reads `md->is_ci` in a loop, or more than once,
reads it once into a local at its start.

The trade is about 500 lines and 22% of the GIL extension (1.72 MB to
1.34 MB) against a few instructions per keyed lookup; numbers are below.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes code.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
covered by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); to be reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed on the C extension under 3.14.7 GIL (4089
passed), 3.14.7t FT (4074 passed) and 3.10 (4093 passed), and on the
pure-Python build with `--no-c-extensions` (1610 passed).
Inlining... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line