aio-libs / multidict / 37513332627

86%

push

github

Drop the update helper wrappers and fold the helpers into their callers (#1715)

<!-- Thank you for your contribution! -->

## What do these changes do?

Removes the nine one-line wrappers around the update helpers
(`_md_update_from_ht_extend`, `_md_update_from_dict_extend_ci`,
`_md_update_from_kwnames_cs` and the rest), and folds
`_md_update_from_ht()`, `_md_update_from_dict()` and
`_md_update_from_kwnames()` into `md_update_from_ht()`,
`md_update_from_dict()` and `md_update_from_kwnames()`, which only
passed `md->is_ci` on.

The wrappers existed so GCC would compile one copy of the inlined helper
per operation or per class. Since #1714 made the helpers plain `static`,
GCC keeps a single shared copy of each anyway, so the wrappers were only
indirection.

Against master, with the smaller callers GCC inlines
`_multidict_ctor_vectorcall()` into both `tp_vectorcall` slots again on
the GIL build: `cls()` gets 2.3 to 3.0% cheaper there, and the
extension's text grows by 1508 bytes. On FT the text shrinks by 596
bytes. No other benchmarked row moves by 0.5% or more.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes code.

## Related issue number

Follow-up to #1714

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change; the
existing suite covers these paths)
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` with the C extension on 3.14.7 GIL (4089 passed, 181
skipped), 3.14.7t FT (4074 passed, 196 skipped) and 3.10.... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line