aio-libs / multidict / 37503098402

86%

push

github

Make the constructor vectorcall helpers plain static functions (#1713)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE static inline` from `_multidict_vectorcall_impl()`
and
`_multidict_ctor_vectorcall()`, leaving both plain `static`.

On the GIL build GCC still inlines both into `multidict_tp_vectorcall()`
and
`cimultidict_tp_vectorcall()`. On the FT build it keeps one shared
out-of-line `_multidict_ctor_vectorcall()` (with
`_multidict_vectorcall_impl()`
inlined into it) that both classes call, so the
`_multidict_ctor_vectorcall`
rule in `tools/check_inlining.py` is removed. The
`_multidict_vectorcall_impl`
rule still passes and is kept.

Callgrind, 3.14.7, instructions per operation, base vs this branch:

| Operation | GIL | FT |
|---|---|---|
| `cls()` | unchanged | +12 to +14 Ir (+1.2% to +1.6%) |
| `cls(items)`, 20 items | unchanged | +11 to +16 Ir (+0.1% to +0.2%) |
| every other row | unchanged | under 0.3% |

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes two forced inlines and one inlining rule.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
covered by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); to be reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` passed on the C extension under 3.14.7 GIL (4089
passed), 3.14.7t FT (4074 passed) and 3.10 (4093 passed), and on the
pure-Python build with `--no-c-extensions` (1610 passed).
Inlining:... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line