aio-libs / multidict / 37502852892

86%

push

github

Make the update and clone helpers plain static functions (#1714)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE` and `inline` from `md_update_from_ht()`,
`md_update_from_dict()`, `md_update_from_seq()`, `md_clone_from_ht()`
and the `_md_update_from_ht()`, `_md_update_from_ht_scan()`,
`_md_update_from_dict()` and `_md_update_from_kwnames()` helpers. GCC
now keeps one shared copy of each instead of a copy per operation or per
class, so the comments describing those copies are removed too.

The trade is deliberate: `update()` and `merge()` with a multidict
argument read the operation at run time now and get 7 to 13% more
instructions, while the extension's text shrinks by 5.5% on GIL and 4%
on FT. Everything else moves by 2% or less.

| Instructions per call, before to after | GIL, 5 / 100 items | FT, 5 /
100 items |
|---|---|---|
| `d.update(md)` | +6.9% / +9.3% | +7.5% / +10.5% |
| `d.merge(md)` | +8.1% / +11.6% | +8.8% / +12.6% |
| `d.extend(md)`, `cls(md)` | 0 to +2% | 0 |
| `d.update(dict)`, table row `update` | +2.3% | +1.8% |
| `d.copy()`, 20 items | +1.0% | 0 |

`CIMultiDict` moves the same way. The pure-Python backend is unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change; the
existing suite covers these paths)
- [x] Documentation reflects the changes
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest -q` with the C ext... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line