aio-libs / multidict / 37488928086

86%

push

github

Make the bulk update helpers plain static functions (#1711)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE static inline` from `_multidict_bulk()` and
`_multidict_bulk_locked()`, so `__init__()`, `extend()`, `update()` and
`merge()` share one out-of-line copy instead of each compiling its own.
`_md_to_dict_scan()` is folded into `md_to_dict()`, which now picks the
entry kind at runtime instead of specializing a copy per kind.
`_multidict_clone_fast()` was already plain `static`.

The `_multidict_bulk` rule in `tools/check_inlining.py` (#1591, "one
shared copy made subclass init 7-8% slower") is removed: the bulk paths
changed a lot since then, and the cost measured now is far smaller.

Callgrind, 3.14.7, instructions per operation, base vs this branch:

| Operation | GIL | FT |
|---|---|---|
| `reinit_items_small` | +1.1% to +1.5% | +0.9% to +1.1% |
| `to_dict()`, 200 entries, 150 keys | -0.7% to +0.9% | -0.7% to +0.9% |
| every other row, `ctor_*` included | under 0.5% | under 0.5%
(`iter_items` +2 Ir) |

`reinit_items_small` is `d.__init__(items)` on an existing instance;
construction itself goes through vectorcall and is unaffected.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, it removes code.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behaviour change;
covered by the existing suite)
- [ ] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); to be reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

Tests: `pytest ... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line