aio-libs / multidict / 37487595456

86%

push

github

Make _md_eq_scan() a plain static function (#1709)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `ALWAYS_INLINE` and `inline` from `_md_eq_scan()`, leaving it a
plain `static` function, and removes the #1676 rule in
`tools/check_inlining.py` that pinned it inline. GCC now emits one
out-of-line copy shared by the four `md_eq()` call sites instead of four
constant-kind copies.

This trades some speed of `md == md` for smaller code: measured with
callgrind on two equal 20-entry dicts, a comparison costs 8-13% more
instructions (table below).

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`md == md` per comparison, callgrind Ir, two equal 20-entry dicts,
`PYTHONHASHSEED=0`, 600 minus 200 iterations with an empty loop
subtracted, CPython 3.14.7 / 3.14.7t:

| build | case | base | this PR | delta |
|---|---|---|---|---|
| GIL | `MultiDict`, ASCII keys | 947.5 | 1053.5 | +11.2% |
| GIL | `MultiDict`, non-ASCII keys | 947.2 | 1054.0 | +11.3% |
| GIL | `CIMultiDict`, either key set | 1952.7 | 2105.0 | +7.8% |
| FT | `MultiDict`, either key set | 1284.3 | 1454.3 | +13.2% |
| FT | `CIMultiDict`, ASCII keys | 2046.3 | 2223.3 | +8.6% |
| FT | `CIMultiDict`, non-ASCII keys | 2046.3 | 2243.3 | +9.6% |

`benchmarks/callgrind_driver.py` has no equality row, so its table does
not co... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line