aio-libs / multidict / 37459905781

86%

push

github

Drop inline from htkeys_build_indices() and _md_del_at_deferred() (#1702)

<!-- Thank you for your contribution! -->

## What do these changes do?

Drops `inline` from `htkeys_build_indices()` and
`_md_del_at_deferred()`, leaving them plain `static`. Unlike most
helpers whose `inline` was dropped in #1689-#1691, here the hint does
change the code: without it GCC keeps both out of line. The first runs
only when a table is rebuilt, the second only when `update()` or
`__setitem__()` drops a duplicate key, so the extra call costs nothing
measurable, and `.text` shrinks by up to 0.9 KB.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, base 2db70d6b vs this branch, equal-length tree and
venv paths, GCC 15, on 3.14.7 and 3.14.7t: every row of `MultiDict` and
`CIMultiDict` moved by 0 Ir. A base-to-base control on a second tree was
identical. The plain `static` build is byte-identical to one with
`NOINLINE` on both helpers, so the attribute is not needed.

`.text`: 244736 -> 243840 (3.14.7), 249936 -> 249744 (3.14.7t), 241968
-> 241200 (3.10.17). FT `Py_DECREF` and `_Py_NewRef` stay out of line,
as on master.

Tests: `pytest -q` on 3.14.7 (4089 passed), 3.14.7t (4074 passed) and
3.10.17 (4093 passed). `tools/check_inlining.py` pass... (continued)

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line