aio-libs / multidict / 37461206892

86%

push

github

Drop NOINLINE from md_reserve() and md_reserve_batch() (#1705)

<!-- Thank you for your contribution! -->

## What do these changes do?

Follows up #1697 by dropping `NOINLINE` from `md_reserve()` and
`md_reserve_batch()`, leaving them plain `static`. The attribute is not
needed: without `inline`, GCC already keeps `md_reserve_batch()` out of
line, which is where the speed and most of the size came from.
`md_reserve()` goes back to being inlined into its callers on GIL
builds; that costs 0.6 to 0.8 KB of `.text` against master, but no
measurable time.

## Are there changes in behavior for the user?

No.

## Is it a substantial burden for the maintainers to support this?

No, one attribute fewer to keep in sync across compilers.

## Related issue number

N/A

## Checklist

- [x] I think the code is well written
- [ ] Unit tests for the changes exist (N/A, no behavior change)
- [x] Documentation reflects the changes (N/A)
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt` (N/A)
- [x] Add a new news fragment into the `CHANGES/` folder
- [x] `make doc-spelling` passes and any new technical words are added
to `docs/spelling_wordlist.txt`

Drafted with Claude Code (Claude Opus 5.5); reviewed by @asvetlov.

<details>
<summary>Agent run details (optional, for reviewers)</summary>

`benchmarks/callgrind_driver.py --include-multidict-only`,
`PYTHONHASHSEED=0`, base 580c2f0d vs this branch, equal-length tree and
venv paths, GCC 15, on 3.14.7 and 3.14.7t: every row of `MultiDict` and
`CIMultiDict` moved by 0 Ir.

`.text` against master: +608 B (3.14.7), +48 B (3.14.7t), +832 B
(3.10.17). Out of line: `md_reserve_batch` on every build, `md_reserve`
on 3.14.7t only. FT `Py_DECREF` and `_Py_NewRef` stay out of line, as on
master.

Tests: `pytest -q` on 3.14.7 (4089 passed), 3.14.7t (4074 passed) and
3.10.17 (4093 passed). `tools/check_inlining.py` passes on 3.14.7 and
3.14.7t. Pre-commit and `make doc-spelling` pass.
</details>

793 of 1586 branches covered (50.0%)

Branch coverage included in aggregate %.

9353 of 10217 relevant lines covered (91.54%)

1.83 hits per line